fix: Wdangling-assignment with clang 21#246
Merged
Merged
Conversation
steve-chavez
force-pushed
the
clang-stuff
branch
2 times, most recently
from
November 15, 2025 02:13
5f08297 to
d3e8464
Compare
steve-chavez
changed the title
steve-chavez
marked this pull request as ready for review
November 15, 2025 02:14
laurenceisla
approved these changes
Nov 15, 2025
steve-chavez
force-pushed
the
clang-stuff
branch
from
November 15, 2025 03:09
d3e8464 to
e6e78a9
Compare
Upgrade to nixpkgs 2025-11-13 to obtain clang 21. * compile with Wdangling-assignment from clang 21 * fix EREPORT_CURL_MULTI_SETOPT compile failures due to type mismatch
steve-chavez
force-pushed
the
clang-stuff
branch
from
November 15, 2025 03:18
e6e78a9 to
715b5ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #245. The compile error can be seen on https://github.com/supabase/pg_net/actions/runs/19381657586/job/55461433507?pr=246.
We compile with clang 21 on macos with this nixpkgs update.