Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Language Generation #808

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ryanpeach
Copy link

What kind of change does this PR introduce?

Feature

What is the current behavior?

Does not generate python,

What is the new behavior?

Practicing TDD, designing tests first and asking the community for feedback.

Additional Comments

I'd like everyones feedback on this format for the python types. I'm using pydantic and mimicing the go structure, since its closest to python dataclasses (basically structs).

@ryanpeach ryanpeach changed the title Python Language Generation Tests Python Language Generation Oct 1, 2024
@ryanpeach
Copy link
Author

ryanpeach commented Oct 1, 2024

I'm not really sure what a lot of these things other than "Tables" are. Materialized Views? Why are there different types for different operations? CompositeTypes?

Anyway, if we agree on the TDD output, I'll make it work 🙂

@ryanpeach
Copy link
Author

I'd also like to do this again, but for rust.

@lwih
Copy link

lwih commented Oct 31, 2024

Man I'm looking forward to that :)

@yangcheng
Copy link

happy to be early tester!

@ryanpeach
Copy link
Author

I've dropped my work on it atm if someone wants to take it the final mile, or wants to answer my questions on this pr, that would be great! Eventually i'll get back to working on supabase.

@troyshu
Copy link

troyshu commented Dec 14, 2024

This is really cool @ryanpeach! Not a supabase team member, just a supabase user who'd love to have python types generated by the CLI. Just wondering, what questions or todos remain before making this an open PR (instead of draft)?

@ryanpeach
Copy link
Author

I need someone to check the tests. I’m know I’ve not covered all cases, but I don’t understand some of the test cases in the other code generators. Basically I need a code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants