fix: accurately determine disk mount for upgrade disk xvdp #1740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jose-ledesma
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During an upgrade, the future data disk is mounted for the data upgrade.
It's observed that since upgrading the base image to ubuntu 24.04 there are occurrences
where the disks are available earlier and assigned inconsistent block device names
Here we install amazon-ec2-utils to give us the ebsnvme-id utility that reads the nvme block devices
and determines their ec2 device name that maps to the nvme device name.
Fallback to current implementation when ebsnvme-id is not correctly installed