Skip to content

Conversation

@edgurgel
Copy link
Member

What kind of change does this PR introduce?

  • Avoid retrying subscription creation for PG changes when params are malformed. They will never succeed.
  • Perform subscription param validation before sending the RPC call and start a database transaction.

What is the current behavior?

Send RPC call which validates subscription params inside a database transaction that gets rollbacked when an error happens. It also retries indefinitely.

@coveralls
Copy link

coveralls commented Oct 27, 2025

Coverage Status

coverage: 86.892% (+0.03%) from 86.862%
when pulling f1a7692 on fix/pg-changes-subscription-error
into 469f56d on main.

@edgurgel edgurgel force-pushed the fix/pg-changes-subscription-error branch from 3259f7b to 8ed8300 Compare October 27, 2025 07:40
@edgurgel edgurgel force-pushed the fix/pg-changes-subscription-error branch from 8ed8300 to f1a7692 Compare October 27, 2025 21:44
@edgurgel edgurgel merged commit 0423825 into main Oct 27, 2025
6 checks passed
@edgurgel edgurgel deleted the fix/pg-changes-subscription-error branch October 27, 2025 22:55
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.57.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants