fix: prevent creating new buckets with the name 'public' #694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Users can create buckets named "public" using the API
What is the new behavior?
A 400 error is thrown if a user tries to create a bucket named "public" via API or S3 protocol
The studio UI already prevents using "public" as a bucket name. This change mirrors that behavior in the API.
Additional context
A bucket with the name "public" causes issues with our api route resolution.
For example, if an object's path is
public/something/file.png
:A request to
/object/info/:bucketName/*
routes to/object/info/public/:bucketName/*
and returns a BUCKET NOT FOUND error for the bucket "something"Also, a request to
/object/:bucketName/*
routes to/object/public/:bucketName/*
and results in the same error