Skip to content

Updating README instructions #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Updating README instructions #44

merged 1 commit into from
Apr 14, 2025

Conversation

z0r1k
Copy link
Contributor

@z0r1k z0r1k commented Apr 3, 2025

What kind of change does this PR introduce?

This is docs update.

What is the current behavior?

Config like this

  - job_name: supabase-foobarbaz-us-east-1-abcdef
    scheme: https
    metrics_path: "/customer/v1/privileged/metrics"
    basic_auth:
      username: service_role
      password: __SUPABASE_SERVICE_ROLE_KEY__
    static_configs:
      - targets: ["foobarbaz-us-east-1-abcdef.supabase.co"]
        labels:
          - supabase_project_ref: "foobarbaz-us-east-1-abcdef"

causes an issue:

"ts=2025-04-02T14:20:12.963Z caller=main.go:512 level=error msg="Error loading config (--config.file=/etc/prometheus/prometheus.yml)" file=/etc/prometheus/prometheus.yml err="parsing YAML file /etc/prometheus/prometheus.yml: yaml: unmarshal errors:\n  line 27: cannot unmarshal !!seq into model.LabelSet\n  line 40: cannot unmarshal !!seq into model.LabelSet""

What is the new behavior?

No more error.

@z0r1k z0r1k requested a review from encima April 3, 2025 10:56
@z0r1k z0r1k requested a review from a team as a code owner April 3, 2025 10:56
@z0r1k
Copy link
Contributor Author

z0r1k commented Apr 4, 2025

It seems like this actually could be a duplicate of #40 but current PR has no merge conflicts.

@encima
Copy link
Member

encima commented Apr 4, 2025

Good catch, I did not see the other PR either so my bad (the same bad that made me do the initial typo...)

Still waiting on backend but maybe the codeowners should change

@z0r1k z0r1k requested a review from a team April 14, 2025 11:10
@z0r1k z0r1k merged commit 019b032 into main Apr 14, 2025
@z0r1k z0r1k deleted the fix/README-project_ref-label branch April 14, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants