fix: improve FunctionRegion type safety and API consistency #759
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, we maintained method overloads to accept both
String
(for regions not yet supported by the client) andFunctionRegion
. With these changes, we now have a singleFunctionRegion
type that, due to itsExpressibleByStringLiteral
conformance, allows passing any new region string, even if not yet supported by the client.This eliminates the need for duplicate method overloads while maintaining the same functionality and improving type safety across the API.
Breaking Changes and Migration
This changes brings more maintainability for the codebase, but it may introduce some breaking changes dependending on how it is being used by customers.
Solution
Or
Test plan
🤖 Generated with Claude Code