Skip to content

Conversation

@som-matrix
Copy link

@som-matrix som-matrix commented Apr 29, 2024

  • Added documentation for a new input parameter "dockerfile", which allows specifying a custom Dockerfile path for the build process. This addition provides flexibility in managing different Docker configurations.

action.yml

  • Streamlined Inputs: Modified the action's inputs by introducing the dockerfile input for specifying Dockerfile paths directly.

entrypoint.sh

  • Implemented support for specifying custom Dockerfile paths, increasing flexibility in Docker image construction.

@som-matrix som-matrix closed this Apr 29, 2024
@som-matrix som-matrix deleted the add-dockerfile-path branch April 29, 2024 13:26
@som-matrix som-matrix restored the add-dockerfile-path branch April 29, 2024 13:32
@som-matrix som-matrix reopened this Apr 29, 2024
@som-matrix
Copy link
Author

Hi folks , please review this when you are free

@brecke
Copy link

brecke commented Jun 19, 2024

This would allow me to skip building my own image during the github action thus saving a lot of billable minutes. Is there something preventing this from being merged? Anything I can do to help?

@som-matrix
Copy link
Author

gentle reminder folks, please review this when you are free

@jsierles
Copy link
Contributor

Hey - it looks like this requires setting a Dockerfile. Wouldn't this be a breaking change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants