feat: only allow secrets to be separated by a newline #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: having multiple secrets separated by spaces is now invalid syntax
Having a secret containing a space " " breaks this action. In my opinion, it's simpler to just require secrets to be split be on their own line, having multiple secrets on the same line is also a little hard on the eyes.
I've smoke tested this on the offending repo that it was breaking for me on, pointing the action to my fork and putting secrets on new lines fixed the issue, the deployment succeeded with correct secrets.
This would be a breaking change for existing workflows, so will require at the very least a minor bump.