Fix API card links to use slugified version in URLs #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API index page card links were using the full version ID (e.g., v0.0.1-rc30) but Astro routes use the slugified version (v001-rc30). This caused all card links on the API reference page to 404. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
CLI Documentation Generator
📚 Commands documented
|
The Python SDK card linked to /sdks/python which doesn't exist yet. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
Preview Deployment
Commit: |
Contributor
Lighthouse Results
|
Contributor
E2E Test Results✅ Tests success Ran against: https://pr-100-superfly-sprites-docs.fly.dev |
The SDK pages at /sdks/* are not accessible on the live site, causing all SDK card links to 404. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/api/v001-rc30/)hrefattributes were using the full version ID (v0.0.1-rc30) but Astro routes use the slugified version (v001-rc30)versionToSlug()to generate correct URLsRoot cause
The
generateIndexPagefunction inscripts/generate-api-docs.tswas generating LinkCard hrefs like/api/v0.0.1-rc30/sprites, but Astro removes dots from directory names when creating routes, so the actual URL is/api/v001-rc30/sprites.Test plan
pnpm buildto regenerate API docs/api/v001-rc30/point to correct slugified URLs🤖 Generated with Claude Code