Update Sprites.Filesystem.build_url to return sprite specific paths…
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1) ## What's The Problem? In the Filesystem module: ```elixir defp build_url(_fs, endpoint, params) do query = URI.encode_query(params) "#{endpoint}?#{query}" end ``` Builds URLs like `/fs/write?`... without the sprite name. The [API docs](https://docs.sprites.dev/api/v001-rc30/filesystem/#write-file) specify: ``` PUT /v1/sprites/{name}/fs/write ``` ## What Was Done? A `Sprites.Sprite.path/3` function was added so any caller that can access a `%Sprite{}`, can generate properly scoped API paths, like: ``` /v1/sprites/my-sprite-name/fs/write ``` **Before:** ```elixir iex(4)> entries = Sprites.Filesystem.ls!(fs, "/home/sprite") ** (Sprites.Error.FilesystemError) File or directory not found: /home/sprite (sprites 0.1.0) lib/sprites/filesystem.ex:199: Sprites.Filesystem.ls!/2 ``` **After:** ```elixir entries = Sprites.Filesystem.ls!(fs, "/home/sprite") => [ ... %{ "isDir" => false, "modTime" => "2026-01-14T00:20:01Z", "mode" => "644", "name" => ".tcshrc", "path" => "/home/sprite/.tcshrc", "size" => 383, "type" => "file" }, %{ "isDir" => false, "modTime" => "2026-01-14T00:20:01Z", "mode" => "644", "name" => ".zshrc", "path" => "/home/sprite/.zshrc", "size" => 1159, "type" => "file" } ] ```
jonlunsford
commented
Jan 22, 2026
| def path(%__MODULE__{name: name}, endpoint, params \\ []) do | ||
| query = if params == [], do: "", else: "?#{URI.encode_query(params)}" | ||
| "/v1/sprites/#{URI.encode(name)}#{endpoint}#{query}" | ||
| end |
Author
There was a problem hiding this comment.
Totally open to a better names, Sprites.Sprite.path was just my first thought :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's The Problem?
In the Filesystem module:
Builds URLs like
/fs/write?... without the sprite name.The API docs specify:
What Was Done?
A
Sprites.Sprite.path/3function was added so any caller that can access a%Sprite{}, can generate properly scoped API paths, like:Before:
After: