Fix TCP proxy socket ownership bug #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two bugs prevented the TCP proxy from forwarding connections: 1. Incorrect PID capture: self() was called inside spawn_link, capturing the spawned accept_loop's PID instead of the GenServer's PID. This caused GenServer.cast to send messages to the wrong process. 2. Missing socket ownership transfer: When accept_loop accepts a socket, it becomes the controlling process. Before the GenServer can transfer ownership to the handler process, it must first own the socket itself. The fix captures the GenServer PID before spawning and transfers socket ownership from accept_loop to GenServer before casting the new_connection message.
jonlunsford
force-pushed
the
fix-proxy-socket-ownership
branch
from
9c2cde6 to
97b537e
Compare
The previous fix transferred socket ownership to the GenServer, but then the spawned handler process couldn't receive data because it wasn't the controlling process. This fix: 1. Spawns the handler process first 2. Transfers socket ownership from GenServer to the handler 3. Signals the handler to proceed once ownership is transferred
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs that prevented the TCP proxy from forwarding connections:
Incorrect PID capture:
self()was called insidespawn_link, capturing the spawned accept_loop's PID instead of the GenServer's PID. This causedGenServer.castto send messages to the wrong process.Missing socket ownership transfer: When
accept_loopaccepts a socket, it becomes the controlling process. Before the GenServer can transfer ownership to the handler process, it must first own the socket itself.Changes
Testing
Added regression tests that verify: