Skip to content

Update tri helper to use BufferGeometry #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update tri helper to use BufferGeometry #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions dist/aframe-particleplayer-component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,11 +968,16 @@ AFRAME.registerComponent('particleplayer', {

// Use triangle geometry as a helper for rotating.
const tri = (function() {
const tri = new THREE.Geometry();
tri.vertices.push(new THREE.Vector3());
tri.vertices.push(new THREE.Vector3());
tri.vertices.push(new THREE.Vector3());
tri.faces.push(new THREE.Face3(0, 1, 2));
const tri = new THREE.BufferGeometry();

const vertices = new Float32Array([
0.0, 0.0, 0.0, // Vertex 1
1.0, 0.0, 0.0, // Vertex 2
0.0, 1.0, 0.0 // Vertex 3
]);

tri.setAttribute('position', new THREE.BufferAttribute(vertices, 3));

return tri;
})();

Expand Down