feat: Phase 4 - responsive & mobile (breakpoints, card fallback, mobile nav, touch targets) - #7
Merged
Merged
Conversation
The sortable table is unusable under 768px, so the dashboard now
watches window.matchMedia("(max-width: 767px)") and forces the card
view when compact; the Table/Cards toggle is hidden via CSS. Resizing
back up restores the previous choice. web-sys gained the
MediaQueryList features for this.
Below the tablet breakpoint the Dashboard/Settings links become a dropdown panel under the sticky header, toggled by a hamburger button (aria-label/aria-expanded set). The panel closes when a link is picked, and the rate badge + theme toggle stay visible in the top row.
Interactive controls (nav links, chips, buttons, inputs, rows) get a 44px minimum height only when the primary pointer is coarse, so touch screens meet comfortable WCAG AA sizing while desktop density stays untouched.
On tablets rows wrap instead of overflowing and drop the last-updated column, and the load-more button stretches full width. On phones the page header stacks, the dashboard toolbar stretches, the summary strip goes 2-up, and comments are hidden in list rows.
All four items are done — breakpoint system, table-to-card fallback, responsive navigation, and coarse-pointer touch targets — with the acceptance criteria met.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
suradet-ps
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4 — Responsive & mobile (ROADMAP)
Six small commits implementing ROADMAP section 4.
c12ef10— mobile <480px / tablet 480–767px / desktop-small 768–1023px / desktop ≥1024px, documented in DESIGN.md "Layout > Breakpoints" with the px values written out instyle.css(CSS variables can't be used inside@media).23c80a5— the dashboard watchesmatchMedia("(max-width: 767px)")and forces the card view below the tablet breakpoint; the Table/Cards toggle is hidden via CSS. Resizing back up restores the previous choice. web-sys gainedMediaQueryList/MediaQueryListEventfeatures.48c270c— hamburger button (witharia-label/aria-expanded); the Dashboard/Settings links become a dropdown panel under the sticky header below 768px and close when a link is picked. Rate badge + theme toggle stay in the top row.dd1c573—@media (pointer: coarse)bumps interactive elements (nav links, chips, buttons, inputs, rows) to a 44px minimum height; desktop density untouched.816c7e3— rows wrap and drop the last-updated column on tablets, load-more stretches full width; on phones the header stacks, toolbar stretches, summary goes 2-up, comments hidden.d7771ac— section 4 checked with notes.Verification
cargo test --workspace --exclude app— 48 passed, no networkcargo check --workspace --target wasm32-unknown-unknown— cleancargo fmt --check— clean; clippy only shows the 2 pre-existing warnings inerror.rstests