chore: move compat dependency to devDependencies

[43081j]

We no longer use it in production code, only in tests. So we can move this to devDependencies now.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 4069ccc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@4069ccc

Published Instant Preview Packages:

• eslint-plugin-svelte: https://pkg.pr.new/eslint-plugin-svelte@4069ccc

View Commit

[JounQin]

Is that really needed? We requires "eslint": "^8.57.1 || ^9.0.0".

[43081j]

from what i remember, in 8.57.1, the flat rule tester is in eslint/use-at-your-own-risk

the index exports the legacy rule tester

in 9.x, the index exports the flat rule tester, and use-at-your-own-risk doesn't export one at all

so we'd need a conditional import of some sort, or continue using the compat utils

[JounQin]

I personally think that's easy enough to use eslint.RuleTester || eslintUnsupportedApi.FlatRuleTester other than depending on a dep we don't use much.

[43081j]

ok i've pushed a change

it seems to work locally with eslint 8. please take a look

[baseballyama]

I think it’s fine, but let’s have @ota-meshi, the owner of eslint-compat-utils, confirm it as well.

[43081j]

when reviewing it, @ota-meshi, keep in mind this is only in tests.

your compat code does some patching up of FlatRuleTester but it doesn't seem we need that here

[ota-meshi]

It's great that eslint-compat-utils is no longer needed! Thanks!

[ota-meshi]

Oh... We should have included the changeset since this is a dependency removal.