fix: support more typescript nodes #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bc27fb4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
manuel3108
changed the title
commit: |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: oxc-project/oxc#11495
This aims at supporting more general ast, that can be parsed by
oxc-parserand then printed by us. Our current testing setup uses acorn, which has some key differences to@typescript-eslint/typesoutlined in the past.I have currently modified the testing setup to use acorn by default. Changing one boolean in the testing setup will also test everything against
oxc-parser. There is probably a nicer way to do this in the future, but it should work out for now.Todo:
wth, is going on withCurrently, we cannot work withoxc-parser's comments? They don't even have a line number or anything, just start and end, but you don't have a clue where those comments should gooxc-parserscomments as they are missing thelocproperty, see estree codegen oxc-project/oxc#11495 (comment), let's handle that at a later pointFix testing setup to use both parsers. What would be the best way to do this? With a command line flag? Or just run both inside the test?For now, both parser run in the same test and execute against the same snapshot. Maps are not compared, as they have noticeable differences. We could either create another .map file for oxc or leave it as is.