Skip to content

svelte-subdivide v3 PR - #23

Open
saabi wants to merge 34 commits into
sveltejs:masterfrom
saabi:v3
Open

svelte-subdivide v3 PR#23
saabi wants to merge 34 commits into
sveltejs:masterfrom
saabi:v3

Conversation

@saabi

@saabi saabi commented Mar 12, 2019

Copy link
Copy Markdown

Not tested yet because compilation is being blocked by an apparent rollup-plugin-svelte unexpected 'nowarn' option bug.

Just opening the PR to possibly avoid somebody else doing the same work in the meanwhile. I'll add any fixes as soon as I can compile and test the upgrade.

Sorry if there's too much commit noise, I was just making sure I detailed my first foreign upgrade for clarity. Should I collapse it?

@saabi

saabi commented Mar 12, 2019

Copy link
Copy Markdown
Author

@saabi

saabi commented Mar 13, 2019

Copy link
Copy Markdown
Author

1 out of 8 tests are passing so far.
Something about fake mouse clicks hapenning before the DOM is ready (in some tests).

@saabi

saabi commented Mar 13, 2019

Copy link
Copy Markdown
Author

Another bug seems to be in Subdivide.beforeUpdate() { createGroup() } and another in that Subdivide.layout is always set to defaultLayout.

@saabi

saabi commented Mar 13, 2019

Copy link
Copy Markdown
Author

After the latest commits it's passing 23 out of 24 tests.

@saabi

saabi commented Mar 13, 2019

Copy link
Copy Markdown
Author

Small woopsie, I bumped the version prematurely accidentally when uploading some changes to package.json

@saabi

saabi commented Mar 13, 2019

Copy link
Copy Markdown
Author

In test #7, where the layout is passed to the constructor, it's creating the Panes in the wrong order internally, though geometrically everything's fine.

It seems one can only tell the difference with static vars, such as the static counter used in the tests that detects instancing order.

So it doesn't pass the test, but I'm not sure it would affect proper functioning in the end.

Also, I'm not sure I can control instancing order.

@saabi

saabi commented Mar 17, 2019

Copy link
Copy Markdown
Author

Regarding the new test... something that instantiates a predefined layout and then clicks, creating new panes.

@blurymind

Copy link
Copy Markdown

really hope to see this working with the newest svelte :)

@milahu

milahu commented Aug 25, 2020

Copy link
Copy Markdown

here is my svelte layout component .... yay repl
https://svelte.dev/repl/dea43257dc9c4236b99d4f51dbe222cd?version=3.24.1

im using a css flex layout, so its zoom agnostic
resize is working 90% after only one day of coding : ]

the goal is to rewrite golden-layout.js in svelte
with support for drag-and-drop, maximize, tabs, menus

another good example is qt dockable widgets

edit: yay github https://github.com/milahu/svelte-layout-resizable

@milahu milahu mentioned this pull request Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants