-
-
Notifications
You must be signed in to change notification settings - Fork 164
fix: rewrite smart quotes logic #1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@Ocean-OS is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new approach seems to error in cases where a title has a single quote character such as https://svelte.dev/docs/kit/images#Vite's-built-in-handling . It changes the single quote to a left single quote when it should be a right single quote as it is currently.
Possible edge cases we should account for:
a) Vite's built-in handling (right single quote)
b) "Vite's built-in handling" (smart double quotes with right single quote)
c) <script lang="ts"> (smart double quotes but in a single word)
I wonder if it's worth adding a unit test for this but I can see we don't have Vitest set up despite having a test command in the root package.json
Closes #781. I'm not entirely sure on what
first
does, or if I'm using it correctly in the logic, but everything else should be good.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.