Skip to content

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Aug 25, 2025

Partial alternative to #16621. That PR is doing more than this one (it addresses a memory leak that this PR doesn't touch) but I don't trust the get_batch logic and so I wanted to see if it was as straightforward as restoring the batch when we restore the effect context, which feels like the correct fix.

This works — we just also need to deactivate the batch when a component unsuspends, in the case that it's inside a pending boundary (otherwise it would already deactivate)

Fixes #16596
Fixes sveltejs/kit#14124

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Aug 25, 2025

🦋 Changeset detected

Latest commit: 5769547

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16668

@dummdidumm dummdidumm merged commit 7105736 into main Aug 25, 2025
16 checks passed
@dummdidumm dummdidumm deleted the restore-batch branch August 25, 2025 18:29
This was referenced Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Can't access property "increment", batch is null null exception if template markup and script contain remote functions
2 participants