fix: restore batch along with effect context #16668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial alternative to #16621. That PR is doing more than this one (it addresses a memory leak that this PR doesn't touch) but I don't trust the
get_batch
logic and so I wanted to see if it was as straightforward as restoring the batch when we restore the effect context, which feels like the correct fix.This works — we just also need to deactivate the batch when a component unsuspends, in the case that it's inside a pending boundary (otherwise it would already deactivate)
Fixes #16596
Fixes sveltejs/kit#14124
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint