-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: run deferred effects in async components #16721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 9373a7e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Ah cool, thanks for starting that! Somewhat related I investigate various inconsistencies around the first run in #16709 and was thinking to add that on top, since it touches adjacent code paths (the PR already fixes the "properly run attachments and other effects created non-sync" part, but not the top level effects part). But I'll hold off from doing that since this looks promising. |
This has been superseded by #16738, closing this. |
Closes #16691
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint