Skip to content

Conversation

Ocean-OS
Copy link
Member

@Ocean-OS Ocean-OS commented Sep 6, 2025

Closes #16691

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Sep 6, 2025

🦋 Changeset detected

Latest commit: 9373a7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Copy link
Contributor

github-actions bot commented Sep 6, 2025

Playground

pnpm add https://pkg.pr.new/svelte@16721

@Ocean-OS Ocean-OS marked this pull request as draft September 6, 2025 03:39
@dummdidumm
Copy link
Member

Ah cool, thanks for starting that! Somewhat related I investigate various inconsistencies around the first run in #16709 and was thinking to add that on top, since it touches adjacent code paths (the PR already fixes the "properly run attachments and other effects created non-sync" part, but not the top level effects part). But I'll hold off from doing that since this looks promising.

dummdidumm pushed a commit that referenced this pull request Sep 11, 2025
Alternative to #16721, partial alternative to #16709. Closes #16691, closes #16627, closes #16582 and #16651 as well.
@Ocean-OS
Copy link
Member Author

This has been superseded by #16738, closing this.

@Ocean-OS Ocean-OS closed this Sep 11, 2025
@Ocean-OS Ocean-OS deleted the gh-16691 branch September 11, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$effects created after the first top-level await never execute
2 participants