This repository was archived by the owner on Feb 15, 2023. It is now read-only.
Move sirv-cli to dev deps #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made a suggestion (#57 (comment)) to possibly move forward with this but honestly my solution still doesn't seem polished so feel free to close if we don't want to explore solutions at this time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been discussed previously, most recently in #91
It appears that
sirv-cliis only needed in production deps in a handful (or just one, Heroku?) of scenarios. Because part of the beauty of svelte is the fact that there are no shipped dependencies, I would argue it's more important to support majority while documenting edge cases.Thoughts? 🤗