Feat: Tile, AnnouncementTile and AnnouncementsList#23
Closed
rensvmoorsel wants to merge 2 commits into
Closed
Conversation
MeesMaas
reviewed
Dec 16, 2025
Contributor
MeesMaas
left a comment
MeesMaas
left a comment
There was a problem hiding this comment.
Ik zou even goed kijken naar de folder structuur van de components.
Het liefste zou je mappen maken met daar in de volgende bestanden:
- AnnouncementTile.tsx
- AnnouncementTile.style.css
- AnnouncementTile.types.ts
Dit is een voorbeeld. (neem dit dus niet letterlijk over)
En dan alles via een index.tsx exporteren zodat je overal gewoon je imports op 1 lijn kan gooien.
Comment on lines
+1
to
+7
| export type Announcement = { | ||
| id: number; | ||
| announcer: string; | ||
| title: string; | ||
| date: Date; | ||
| announcement: string; | ||
| }; |
Contributor
There was a problem hiding this comment.
Deze shit komt uiteindelijk uit de backend toch? Dan kan je beter eerst even de backend afbouwen zodat we het via heyapi kunnen genereren
Contributor
Author
There was a problem hiding this comment.
Yes, maar ik ben met de backend aan het wachten op een PR die open staat :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.