Add note type for activities#1103
Conversation
SanderHageman
left a comment
SanderHageman
left a comment
There was a problem hiding this comment.
Minor changes
Could only partially check because I can't read html/css and barely understand js and haml.
| var par_notes; | ||
| var notes = []; | ||
| console.log(activity.has_notes_checkboxes); | ||
| if (activity.has_notes_checkboxes()) { |
There was a problem hiding this comment.
I also know little JS, however, does it not have switch cases?
There was a problem hiding this comment.
Is there any way to define the enum in 1 place like in activity.rb and reference it from the jabbascript?
There was a problem hiding this comment.
Don't think so, atleast not trivally
|
|
||
| @member = Member.find(current_user.credentials_id) | ||
| @notes = params[:par_notes] | ||
| @notes = params[:par_notes] |
There was a problem hiding this comment.
Why did the linter add a double space? Linters 🤷
| var notes = []; | ||
| console.log(activity.has_notes_checkboxes); | ||
| if (activity.has_notes_checkboxes()) { | ||
| console.log(this.notes.find(":checked")); |
There was a problem hiding this comment.
remove log or cache this.notes call
| '<div class="col-md-12">' + | ||
| '<div class="input-group mb-3">' + | ||
| '<span class="input-group-text">Title</span>' + | ||
| '<input class="form-control" type="text" name="activity[notes_options][]">' + | ||
| "</div>" + | ||
| "</div>" + | ||
| '<div class="col-md-6">' + | ||
| '<div class="input-group mb-3">' + | ||
| '<input class="form-control" type="text" name="activity[notes_options][]">' + | ||
| '<div class="input-group-append">' + | ||
| '<button class="btn btn-sm btn-danger delete-option" type="button">' + | ||
| '<i class="fa fa-fw fa-minus"></i>' + | ||
| "</button>" + | ||
| "</div>" + | ||
| "</div>" + | ||
| "</div>"; |
There was a problem hiding this comment.
Perhaps add some indentation here?
There was a problem hiding this comment.
Might be preferable, however, an even better approach would be to eliminate the need for generating HTML within the JavaScript code altogether.
Make a HAML partial file as a template for the option menu.
In the _edit haml file render the template but keep it hidden with css attributes
Update the code that appends the options HTML to use the cloned template.
Modify the code that sets the input values to target the cloned elements and make it visible
Add an event listener for the "Add Option" button to clone and append the template.
Add an event listener for the "Delete Option" button to remove the corresponding option.
this is not required, but would prevent coding twice when changing the UI
| var activity = this; | ||
| var par_notes; | ||
| var notes = []; | ||
| console.log(activity.has_notes_checkboxes); |
There was a problem hiding this comment.
Shouldn't the console log be removed?
3 participants
I wondered how long it would take to implement this without altering too much in the database. I don’t think this is necessarily the best way to implement it, but it seems fully functional at least.
Only the translations are missing, I think.
