Removed code from the old Mongoose back-end and re-organised menu's#1126
Removed code from the old Mongoose back-end and re-organised menu's#1126SpookyBoy99 wants to merge 3 commits into
Conversation
SilasPeters
left a comment
SilasPeters
left a comment
There was a problem hiding this comment.
Seems fine at first glance, but we should carefully test all/most controllers of koala to see if nothing breaks
|
This PR makes no changes to the database so if something breaks we can easily revert to an earlier deployment and not data will be lost. I have looked through all the pages that I know of and they seem functional (including the export of transactions) |
|
Looks good to me. @SilasPeters are there any blockers left on this PR? |
|
I am not aware of any blockers. I would say let's review, test and merge! But @stickyPiston probably has a better view on this. |
|
If @stickyPiston and @TobiasDeBruijn have time for a quick review, I can resolve the merge conflicts and merge this PR. I don't have a lot of time these days so if many more merge conflicts will arise in the mean time I don't think I will have enough time to resolve them in the future. |
SilasPeters
left a comment
SilasPeters
left a comment
There was a problem hiding this comment.
Quick scan. Our time would be better spend to test every endpoint in staging.
| @limit = params[:limit] ? params[:limit].to_i : 50 | ||
|
|
||
| @pagination, @impressions = pagy(Impression.all.order(created_at: :desc), | ||
| items: params[:limit] ||= 50) |
There was a problem hiding this comment.
| items: params[:limit] ||= 50) | |
| items: @limit |
3 participants
Closes #1109. The Mongoose data will not deleted from the database with this PR and Mongoose top-ups are still shown in the transaction history and exports.