fix: split preview deploy to prevent secret exposure from fork PRs - #5309
Open
jackmisbach wants to merge 2 commits into
Open
fix: split preview deploy to prevent secret exposure from fork PRs#5309jackmisbach wants to merge 2 commits into
jackmisbach wants to merge 2 commits into
Conversation
Preview Deploy
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
The current pr-preview.yml uses pull_request_target and checks out the fork PR code in the same job that has access to Cloudflare deployment credentials. While the credentials are scoped to the deploy step, running untrusted code in the same job as secrets is a known anti-pattern, and it is possible to get the Cloudflare apiToken and accountId here. Although I'm sure the API token is scoped down to the PR preview pages and doesn't have access to anything else, regardless, or so I'd presume?
However, this PR splits the workflow into two for security purposes:
reference: https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/