fix(transform-imports): Transform side-effect imports#473
Merged
Conversation
|
|
|
kdy1
approved these changes
Jun 13, 2025
kdy1
enabled auto-merge (squash)
June 13, 2025 15:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #474
Original issue: Imports with side effects were being incorrectly removed. The expected behavior is to retain the import and apply the transformation.
The current behavior causes issues when the code includes TypeScript side-effect imports. These are skipped by the plugin and remain untransformed, which leads to runtime failures in Node.js (since it cannot import .ts files directly).