Skip to content

fix(formatjs): Add support for string concatenation in message definitions #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 21, 2025

Conversation

rrosenshain-sc
Copy link
Contributor

Fixes #446

[warning: AI driven solution using Opus 4.1]

This update introduces the ability to handle string concatenation in both defaultMessage and FormattedMessage JSX components. New tests have been added to ensure correct transformation of concatenated strings into a single message. Additionally, helper functions for evaluating binary expressions have been implemented in the Rust codebase to support this feature.

…itions

This update introduces the ability to handle string concatenation in both `defaultMessage` and `FormattedMessage` JSX components. New tests have been added to ensure correct transformation of concatenated strings into a single message. Additionally, helper functions for evaluating binary expressions have been implemented in the Rust codebase to support this feature.
Copy link

changeset-bot bot commented Aug 12, 2025

⚠️ No Changeset found

Latest commit: d2c83a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rrosenshain-sc rrosenshain-sc changed the title feat(formatjs): Add support for string concatenation in message definitions fix(formatjs): Add support for string concatenation in message definitions Aug 12, 2025
@rrosenshain-sc rrosenshain-sc requested a review from kdy1 August 19, 2025 02:57
@kdy1 kdy1 merged commit d85f92f into swc-project:main Aug 21, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

formatjs: concatenated strings break (unlike babel)
3 participants