Skip to content

DRAFT: custom lexer in ecma parser. #10385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Apr 17, 2025

This is a draft PR still under active development. I'm primarily verifying CI is green at this stage - please hold off on reviewing until marked ready.

@bvanjoi bvanjoi requested a review from a team as a code owner April 17, 2025 06:23
Copy link

changeset-bot bot commented Apr 17, 2025

⚠️ No Changeset found

Latest commit: 40b4e06

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bvanjoi bvanjoi marked this pull request as draft April 17, 2025 06:23
Copy link

codspeed-hq bot commented Apr 17, 2025

CodSpeed Performance Report

Merging #10385 will degrade performances by 18.81%

Comparing bvanjoi:rm-token-contexts (40b4e06) with main (f802892)

Summary

⚡ 1 improvements
❌ 23 regressions
✅ 128 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/codegen/with-parser/colors 188.6 µs 192.9 µs -2.26%
es/lexer/angular 12.2 ms 14.5 ms -15.75%
es/lexer/backbone 1.7 ms 2 ms -17.95%
es/lexer/cal-com 33.8 ms 40.4 ms -16.18%
es/lexer/colors 44.2 µs 49.5 µs -10.7%
es/lexer/jquery 8.8 ms 10.8 ms -18.34%
es/lexer/jquery mobile 13.6 ms 16.5 ms -17.77%
es/lexer/mootools 7.1 ms 8.8 ms -18.81%
es/lexer/three 43.2 ms 52.1 ms -17.18%
es/lexer/typescript 236.2 ms 281.1 ms -15.96%
es/lexer/underscore 1.4 ms 1.7 ms -18.3%
es/lexer/yui 7.2 ms 8.7 ms -17.08%
es/parser/angular 29.6 ms 30.5 ms -2.98%
es/parser/backbone 4.6 ms 4.7 ms -3.18%
es/parser/cal-com 90,419.6 µs 325.3 µs ×280
es/parser/colors 122.1 µs 125.3 µs -2.59%
es/parser/jquery 23.7 ms 24.5 ms -3.25%
es/parser/jquery mobile 36.4 ms 37.6 ms -3.23%
es/parser/mootools 18.8 ms 19.5 ms -3.38%
es/parser/three 112.3 ms 115.7 ms -2.89%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@kdy1 kdy1 added this to the Planned milestone Apr 17, 2025
@bvanjoi bvanjoi force-pushed the rm-token-contexts branch from 0fb9940 to 3bf20b8 Compare April 19, 2025 08:58
@bvanjoi bvanjoi force-pushed the rm-token-contexts branch 2 times, most recently from 235452f to b65c7d0 Compare April 20, 2025 11:04
@bvanjoi bvanjoi force-pushed the rm-token-contexts branch from b65c7d0 to 40b4e06 Compare April 20, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants