ci: allow memmap2 advisory - #11961
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57d0037e0a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| "RUSTSEC-2026-0095", # wasmtime 38 has no patched release in this major line (transitive dep via swc_plugin_runner) | ||
| "RUSTSEC-2026-0096", # wasmtime 38 has no patched release in this major line (transitive dep via swc_plugin_runner) | ||
| "RUSTSEC-2026-0114", # wasmtime 38 has no patched release in this major line (transitive dep via swc_plugin_runner) | ||
| "RUSTSEC-2026-0186", # memmap2 is constrained by shared-buffer 0.1.4 via wasmer; shared-buffer has no patched release and only uses Mmap::map |
There was a problem hiding this comment.
Verify the direct wasmer-compiler memmap2 path
This ignore suppresses RUSTSEC-2026-0186 for every memmap2 0.6.2 occurrence, but the checked lockfile shows wasmer-compiler 6.1.0-rc.3 also depends directly on memmap2 (Cargo.lock:8767-8780), in addition to the shared-buffer path. When swc_plugin_backend_wasmer is enabled it pulls in Wasmer/Cranelift (Cargo.lock:7457-7467), so the exemption currently lets cargo deny pass without covering that direct dependency; please either verify/upgrade the Wasmer compiler path as well or avoid the global advisory ignore.
Useful? React with 👍 / 👎.
Merging this PR will improve performance by 2.37%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
Description:
Allow
RUSTSEC-2026-0186indeny.tomlsocargo deny checkpasses after the new RustSec advisory formemmap2 0.6.2.memmap2is constrained byshared-buffer 0.1.4, which is pulled in through Wasmer. There is no newer crates.io release ofshared-buffer, and local source inspection shows it only usesMmap::map, not the affected range advice/flush APIs described by the advisory.Validation:
git submodule update --init --recursivecargo deny checkcargo fmt --allcargo clippy --all --all-targets -- -D warningsBREAKING CHANGE:
None.
Related issue (if exists):
CI job: https://github.com/swc-project/swc/actions/runs/28000731021/job/82872355038