fix(es/decorators): drop params from getter replacing decorated private method

[ken7253 (ken7253)]

Description:

Decorating a private method rewrites it into a private getter returning the extracted call target. The rewrite reset is_async and is_generator but not params, so a method with parameters produced an invalid getter:

class Foo {
  @dec
  #a(x, y) {
    return x + y;
  }
}

get #a(x, y) {  // SyntaxError: Getter must not have any formal parameters
    return _call_a;
}

Clearing params on the switch to MethodKind::Getter fixes it. The parameters remain on the extracted function.

No existing test caught this: codegen emits Function::params regardless of MethodKind, and the parser's GetterParam check is a recoverable error the fixture harness discards. Only running the output surfaces it, so the 2023-11 fixture includes an exec case.

Related issue (if exists):

None

[changeset-bot]

🦋 Changeset detected

Latest commit: 21db9d6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codspeed-hq]

Merging this PR will not alter performance

✅ 200 untouched benchmarks
⏩ 61 skipped benchmarks¹

---

_{Comparing ken7253:fix/decorators-private-method-getter-params (21db9d6) with main (f6d5bd1)²}

Footnotes

1. 61 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (7a29dc7) during the generation of this report, so f6d5bd1 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[CLAassistant]

All committers have signed the CLA.