Fix HTTPBodySequence for large requests (adds AsyncBufferedPrefixSequence)#140
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
- Coverage 94.85% 94.83% -0.02%
==========================================
Files 60 61 +1
Lines 3943 3971 +28
==========================================
+ Hits 3740 3766 +26
- Misses 203 205 +2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #139
HTTPRequest.bodySequenceis aways backed by one of the the following concrete types:AsyncSharedReplaySequence: Sequence that can be safely iterated multiple times by one or more consumers concurrently. It is buffered in memory and is used for all requests with body less than2_097_152bytesFlyingFox/FlyingFox/Sources/HTTPServer+Configuration.swift
Line 46 in fe9437d
AsyncSocketReadSequenceSequence that is backed directly by the socket itself. Used for all requests with body greater than2_097_152bytes.A bug exists when
AsyncSocketReadSequenceis used, because the sequence is only terminated when the underlying socket is closed, the sequence hangs when all bytes are read but the socket remains open.This PR adds
AsyncBufferedPrefixSequencewhich wraps the underlyingAsyncSocketReadSequenceterminating the sequence when all bytes have been read.