Fix importing of latest protobuf version #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RReichert
commented
Apr 28, 2025
| @@ -1,6 +1,8 @@ | |||
| include("GenericFindDependency") | |||
|
|
|||
| option(ABSL_PROPAGATE_CXX_STD "Use CMake C++ standard meta features (e.g. cxx_std_11) that propagate to targets that link to Abseil" true) | |||
| option(protobuf_INSTALL "Install protobuf binaries and files" OFF) | |||
There was a problem hiding this comment.
Need to apply these changes here because gRPC also include protobuf internally
armallen
approved these changes
Apr 28, 2025
RReichert
pushed a commit
to swift-nav/albatross
that referenced
this pull request
Apr 28, 2025
…on (#181) (#511) Automated PR by Jenkins. If CI has passed successfully, merge away! **cmake** 30226aa8 -> 8920f2a3 - 8920f2a3 : Fix importing of latest protobuf version (swift-nav/cmake#181) This pull request was created by https://jenkins.ci.swift-nav.com/job/CI%20Infra/job/submodule-update/19843/.
RReichert
pushed a commit
to swift-nav/libsbp
that referenced
this pull request
Apr 28, 2025
…on (#181) (#1474) Automated PR by Jenkins. If CI has passed successfully, merge away! **cmake** 30226aa8 -> 8920f2a3 - 8920f2a3 : Fix importing of latest protobuf version (swift-nav/cmake#181) This pull request was created by https://jenkins.ci.swift-nav.com/job/CI%20Infra/job/submodule-update/19843/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In order to use the latest protobuf
v5.29.0version, we need to tweek some compile options to remove the installation commands from a few targets, otherwise you will get the following errors: