[fix] The library must compile when no traits are enabled #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsto
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make required changed to ensure the library compiles when no traits are enabled (fix: #562)
Add an example project that serves as test in the CI
Motivation:
Recent changes introduced compilation errors when no traits are enabled.
Modifications:
LambdaResponseStreamWriter.writeStatusAndHeaders()moved to theFoundationSupportdirectory where all classes and struct depending onEncodableandDecodableare located, protected by#if FoundationJSONSupportLambdaRuntime.run()method when ServiceLifeCycle is disabled in now public (and therefore can not be@inlinableanymore)Result:
The Library now compiles when no default traits are enabled.
This is flagged
semver/majorbecause we change the public APILambdaRuntime.run()