Respect maximumCount argument in request reader #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad(maximumCount:body:)`
gjcairo
reviewed
Jan 9, 2026
Comment on lines
+80
to
+82
| if let maximumCount, maximumCount < element.readableBytes { | ||
| throw .first(LimitExceeded()) | ||
| } |
Collaborator
There was a problem hiding this comment.
I'm actually unsure about this. I wonder if we should only return maximumCount bytes and keep the rest of the bytes in a local buffer until the next read call, or if we should throw. The only way to get out of this throwing scenario is by increasing the count, which sounds potentially problematic.
| //===----------------------------------------------------------------------===// | ||
|
|
||
| /// Data available in a read buffer exceeded the caller-specified maximum count. | ||
| struct LimitExceeded: Error { |
Collaborator
There was a problem hiding this comment.
I'm not sure we need this based on the other comment but if we do, I think it makes more sense to have a namespace for this, either by nesting it inside the HTTPRequestConcludingAsyncReader or by having some other error namespace and nesting it there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently, we do not use the
maximumCountargument inHTTPRequestConcludingAsyncReader'sread(maximumCount:body:)method.Modifications:
Updated
HTTPRequestConcludingAsyncReader/read(maximumCount:body:)to throw aLimitExceedederror when the bytes available exceedmaximumCount.Result:
The
maximumCountargument is now respected inHTTPRequestConcludingAsyncReader/read(maximumCount:body:).