Skip to content

Conversation

Gabe-Mitnick
Copy link

@Gabe-Mitnick Gabe-Mitnick commented Aug 17, 2025

I'm a big fan of SwiftBar, thanks for maintaining it!

This PR fixes a couple of small visual issues I noticed in the Plugin Repository window

  • When an image for plugin is available, it's too small
  • Extra corner radius on the modal view, even though the system UI already includes a corner radius
Before After
scrnsht 1 scrnsht 9
  • When the app icon is displayed as a fallback image, the opacity and size are different depending on whether the image URL is missing (small transparent icon) or the image URL fails to load* (big opaque icon)

*Lots of plugins from the xbar repository JSON have image URLs that point to 0-bit files, like https://xbarapp.com/docs/plugins/AWS/cloudwatch-alarms.30s.py.png, even though the plugin's contents contain a valid image URL. This PR doesn't fix that issue 😅

Before After
scrnsht scrnsht 8
scrnsht 2 scrnsht 10
scrnsht 7 scrnsht 11

^ No change to settings page — this plugin with no image URL still doesn't show the app icon.

  • ImageVIew.swift had a typo in the filename

@melonamin
Copy link
Member

Thanks! I'll merge it a bit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants