Skip to content

[lldb] Script determinism of TestSwiftActorUnprioritisedJobs #10435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: stable/20240723
Choose a base branch
from
Open
Original file line number Diff line number Diff line change
@@ -1,30 +1,62 @@
import time
from contextlib import contextmanager
import lldb
from lldbsuite.test.decorators import *
from lldbsuite.test.lldbtest import *
from lldbsuite.test import lldbutil


@contextmanager
def _managed_async(dbg):
async_state = dbg.GetAsync()
try:
yield
finally:
dbg.SetAsync(async_state)


class TestCase(TestBase):

@swiftTest
@skipUnlessFoundation
@skipIfWindows # temporarily skip test until fails can be investigated
@skipIfLinux # temporarily skip test until fails can be investigated
@skipIfDarwin # temporarily skip test until fails can be investigated
def test_actor_unprioritised_jobs(self):
"""Verify that an actor exposes its unprioritised jobs (queue)."""
self.build()
_, _, thread, _ = lldbutil.run_to_source_breakpoint(
self, "break here", lldb.SBFileSpec("main.swift")
_, process, thread, _ = lldbutil.run_to_source_breakpoint(
self,
"break here",
lldb.SBFileSpec("main.swift"),
only_one_thread=False,
)
frame = thread.GetSelectedFrame()

stopped_threads = [
t for t in process.threads if t.stop_reason == lldb.eStopReasonBreakpoint
]

# If only one breakpoint has hit, run the other threads to reach the
# state where both breakpoints have hit.
if len(stopped_threads) == 1:
with _managed_async(self.dbg):
# Suspend the current thread.
thread.Suspend()
# Run the other threads until the second breakpoint hits.
self.dbg.SetAsync(False)
process.Continue()

# Get the frame for the the breakpoint hit in `main()`.
frame = lldb.SBFrame()
for t in process.threads:
if t.stop_reason == lldb.eStopReasonBreakpoint:
if "Entry.main()" in t.frame[0].name:
frame = t.frame[0]
break

defaultActor = frame.var("a.$defaultActor")
self.assertEqual(defaultActor.summary, "running")
unprioritised_jobs = defaultActor.GetChildMemberWithName("unprioritised_jobs")

# There are 4 child tasks (async let), the first one occupies the actor
# with a sleep, the next 3 go on to the queue.
# TODO: rdar://148377173
# self.assertEqual(unprioritised_jobs.num_children, 3)
self.assertEqual(unprioritised_jobs.num_children, 3)
self.assertEqual(defaultActor.summary, "running")
for job in unprioritised_jobs:
self.assertRegex(job.name, r"^\d+")
self.assertRegex(job.summary, r"^id:\d+ flags:\S+")
self.assertRegex(job.summary, r"^id:[1-9]\d* flags:\S+")
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import Foundation

actor Actor {
var data: Int = 15

func occupy() async {
Thread.sleep(forTimeInterval: 100)
print("break here")
}

func work() async -> Int {
Expand All @@ -17,6 +15,10 @@ actor Actor {
@main struct Entry {
static func main() async {
let a = Actor()

// Cause execution to pass through Swift Concurrency's threads.
await a.work()

async let _ = a.occupy()
async let _ = a.work()
async let _ = a.work()
Expand Down