[lldb][swift] Query name of problematic variable when emitting diagnostics #10780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stics When evaluating an expression, LLDB attempts to find type information for all variables in scope. The current error messages imply that we only fail if the type for self cannot be realized, and this seems to be what happens. However, the code is written in such a way that allows for other failures too. This commit enhances the error message to print the name of the variable that caused the failure, instead of hardcoding "self".
|
Talked offline about this, the function was indeed correct in that it always fails for self only, so the message is not exactly wrong. However it should not talk about the type of self, sometimes it is the value of self that fails. We should propagate the errors from value objects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When evaluating an expression, LLDB attempts to find type information for all variables in scope. The current error messages imply that we only fail if the type for self cannot be realized, and this seems to be what happens. However, the code is written in such a way that allows for other failures too. This commit enhances the error message to print the name of the variable that caused the failure, instead of hardcoding "self".