Target: Add target option for disabling `AArch64_ELFTargetObjectFile:… #10795
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
reviewed
Jun 6, 2025
There was a problem hiding this comment.
@ahmedbougacha does this one seem fine to upstream to you? Isn't the target linker check (llvm#78003 (comment)), but at least allows customizing whether it's enabled or not.
AnthonyLatsis
force-pushed
the
stable/20250402
branch
from
fa68daf to
6ba0f08
Compare
…:SupportIndirectSymViaGOTPCRel` The Swift compiler needs to disable this option in order for the standard library to link successfully on Linux. See: - swiftlang#9339 - llvm#78003
AnthonyLatsis
force-pushed
the
stable/20250402
branch
from
6ba0f08 to
7708d30
Compare
AnthonyLatsis
requested review from
daniel-grumberg,
QuietMisdreavus,
cyndyishida,
dcci and
lanza
as code owners
bnbarham
approved these changes
Jun 13, 2025
|
@swift-ci please test |
AnthonyLatsis
merged commit 1468247
into
swiftlang:stable/20250601
0 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…:SupportIndirectSymViaGOTPCRel`
The Swift compiler needs to disable this option in order for the standard library to link successfully on Linux.
See:
Paired with swiftlang/swift#82060.