[IncludeTree] Do not pass compilation directories #11034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using include-tree, all the relative paths references should be turned into absolute path already. There is no need to pass options like `-fdebug-compilation-dir` for debug info generation as it makes cache hit less likely when two identical compilations where performed with different compilation directories.
cachemeifyoucan
requested review from
kastiglione,
akyrtzi,
adrian-prantl and
benlangmuir
cachemeifyoucan
commented
Jul 21, 2025
| @@ -3332,6 +3332,10 @@ llvm::DIModule *CGDebugInfo::getOrCreateModuleRef(ASTSourceDescriptor Mod, | |||
| std::string Remapped = remapDIPath(Path); | |||
| StringRef Relative(Remapped); | |||
| StringRef CompDir = TheCU->getDirectory(); | |||
| // If compilation is not empty, return the path as it is. | |||
There was a problem hiding this comment.
Note: this can probably go upstream but I can't write a test case for it since it only manifest for a file system that doesn't have current working directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using include-tree, all the relative paths references should be turned into absolute path already. There is no need to pass options like
-fdebug-compilation-dirfor debug info generation as it makes cache hit less likely when two identical compilations where performed with different compilation directories.