stable/21.x: [Coro] RetconOnceDynamic: Distinguish frame allocs and pass frame pointers. #11671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
general-coro/20251009/1
branch
from
5a09228 to
ddd60f2
Compare
Deallocation has an address to be deallocated, not a size.
nate-chandler
force-pushed
the
general-coro/20251009/1
branch
from
ddd60f2 to
ce05a0a
Compare
nate-chandler
force-pushed
the
general-coro/20251009/1
branch
from
ce05a0a to
4e8c83c
Compare
nate-chandler
changed the title
aschwaighofer
approved these changes
Oct 23, 2025
Doing so enables implementations to allocate extra space in a header.
Doing so enables allocator implementation to use the frame to store contextual info.
Mark the allocator parameter passed to the allocation functions swiftcoro.
nate-chandler
force-pushed
the
general-coro/20251009/1
branch
from
4e8c83c to
a1c6568
Compare
|
Fixed. |
|
@swift-ci test llvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable allocator implementations that store context in a frame header.