Add missing LLVM_ABI annotations#12674
Open
Steelskin wants to merge 1 commit intoswiftlang:stable/21.xfrom
Open
Add missing LLVM_ABI annotations#12674Steelskin wants to merge 1 commit intoswiftlang:stable/21.xfrom
Steelskin wants to merge 1 commit intoswiftlang:stable/21.xfrom
Conversation
This is required to build LLVM as a DLL on Windows for the Swift toolchain. The missing annotations either concern: * CAS, which is partially upstreamed, with many APIs not present upstream. * Files that have been removed or renamed upstream. * Annotations that are already present upstream. The effort to ship the Swift toolchain with LLVM built as a DLL is tracked in swiftlang/swift#85241.
Author
|
@swift-ci please test |
Steelskin
changed the title
Author
|
@swift-ci please test macos platform |
Author
|
@swift-ci please test windows platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to build LLVM as a DLL on Windows for the Swift toolchain. The missing annotations either concern:
The effort to ship the Swift toolchain with LLVM built as a DLL is tracked in swiftlang/swift#85241.