🍒 [lldb-dap][windows] add integratedTerminal and externalTerminal support#12726
Open
charles-zablit wants to merge 4 commits intoswiftlang:stable/21.xfrom
Open
🍒 [lldb-dap][windows] add integratedTerminal and externalTerminal support#12726charles-zablit wants to merge 4 commits intoswiftlang:stable/21.xfrom
charles-zablit wants to merge 4 commits intoswiftlang:stable/21.xfrom
Conversation
This patch fixes an incorrect name of the `lldb-dap` process on Windows by appending `.exe` to the name. This is a prelude to llvm#174635. (cherry picked from commit ebdaea6)
This patch is a prelude to llvm#174635. It implements a Windows version of the `FifoFile` class used in lldb-dap. This change is not used as is, it will be used when llvm#174635 lands. (cherry picked from commit 0a36c87)
charles-zablit
force-pushed
the
cz/lldb/windows/dap-to-stable
branch
from
4a6cb86 to
bb31d65
Compare
Author
|
@swift-ci please test |
…rt (llvm#174635) (cherry picked from commit 1f0638c)
charles-zablit
force-pushed
the
cz/lldb/windows/dap-to-stable
branch
from
bb31d65 to
f4bcfaa
Compare
Author
|
@swift-ci please test |
adrian-prantl
approved these changes
Apr 21, 2026
Author
|
@swift-ci please smoke test |
Author
|
@swift-ci please test windows |
charles-zablit
force-pushed
the
cz/lldb/windows/dap-to-stable
branch
from
9e0af59 to
9150cb1
Compare
Author
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires the following PRs to be merged: