LLDB: add basic Wasm e2e test with WasmKit#12732
Open
MaxDesiatov wants to merge 1 commit intoswiftlang:stable/21.xfrom
Open
LLDB: add basic Wasm e2e test with WasmKit#12732MaxDesiatov wants to merge 1 commit intoswiftlang:stable/21.xfrom
MaxDesiatov wants to merge 1 commit intoswiftlang:stable/21.xfrom
Conversation
Author
|
@swift-ci test |
felipepiovezan
left a comment
There was a problem hiding this comment.
Jonas is probably a better person to comment here, but the one thing that sticks out to me is that this test takes a different approach to compiling the code. Is it not possible to use the usual Makefile approach? This pushes all the test suite configuration steps (environment variables, etc) to the build stage (of lldb itself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow up PR on
swiftlang/swiftwill run this test after WasmKit is built. In the meantime, this test can be invoked manually fromswiftlangrepositories checkout, for example this way on macOS for a--release-debuginfobuild: