[CAS] Sync LLVMCAS library implementation to next#12794
Open
cachemeifyoucan wants to merge 6 commits intoswiftlang:stable/21.xfrom
Open
[CAS] Sync LLVMCAS library implementation to next#12794cachemeifyoucan wants to merge 6 commits intoswiftlang:stable/21.xfrom
cachemeifyoucan wants to merge 6 commits intoswiftlang:stable/21.xfrom
Conversation
cachemeifyoucan
force-pushed
the
eng/PR-sync-cas-next-to-21.x
branch
from
4bb110d to
8fefe79
Compare
Author
|
@swift-ci please test |
cachemeifyoucan
force-pushed
the
eng/PR-sync-cas-next-to-21.x
branch
from
8fefe79 to
a7d5f04
Compare
Author
|
@swift-ci please test |
Author
|
@swift-ci please test |
Author
|
@swift-ci please test |
Update the downstream code to use upstreamed content.
Add MappedFileRegionArena which can be served as a file system backed persistent memory allocator. The allocator works like a BumpPtrAllocator, and is designed to be thread safe and process safe. The implementation relies on the POSIX compliance of file system and doesn't work on all file systems. If the file system supports lazy tail (doesn't allocate disk space if the tail of the large file is not used), user has more flexibility to declare a larger capacity. The allocator works by using a atomically updated bump ptr at a location that can be customized by the user. The atomic pointer points to the next available space to allocate, and the allocator will resize/truncate to current usage once all clients closed the allocator. Windows implementation contributed by: @hjyamauchi
Replace all CAS library and header files with their versions from origin/next to bring upstream LLVMCAS changes to stable/21.x. Key changes: - HashMappedTrie removed (replaced by ADT/TrieRawHashMap) - OnDiskHashMappedTrie → OnDiskTrieRawHashMap - MappedFileRegionBumpPtr → MappedFileRegionArena - Add OnDiskDataAllocator, DatabaseFile, NamedValuesSchema - Add FileOffset.h, OnDiskTrieRawHashMap.h - Update OnDiskGraphDB, UnifiedOnDiskCache, ActionCache APIs - createCASFromIdentifier now returns pair<ObjectStore, ActionCache> - LLVM_ENABLE_ONDISK_CAS moved to llvm-config.h.cmake - TrieRawHashMap: add print()/dump() support
Replace all CAS test files with their versions from origin/next to match the updated LLVMCAS library implementation.
Update all downstream consumers for the new LLVMCAS APIs: - GRPCRelayCAS: HashMappedTrie → TrieRawHashMap - RemoteCachingService: new ObjectStoreCreateFuncTy (pair return) - libCASPluginTest: KVPut/KVGet → cachePut/cacheGet, ObjectHandle - llvm-cas: rewrite with tablegen-based option parsing - llvm-cas-dump, llvm-cas-object-format: .first for pair return - llvm-cas-test: Config.def macro-based parameters - llc, llvm-mc: createCASFromIdentifier returns pair - cc1depscan_main: bool → LockKind::Exclusive
llvm#192565) When opening an existing large CAS using a smaller requested mapping size, the file size can be smaller than capacity while holding only a shared lock. Replace the assertion with a graceful lock upgrade to exclusive before resizing the file.
cachemeifyoucan
force-pushed
the
eng/PR-sync-cas-next-to-21.x
branch
from
a7d5f04 to
b0d33a4
Compare
Author
|
@swift-ci please test |
akyrtzi
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync LLVM CAS library implementation to upstreamed version. This Allows:
Add bug fixes from latest LLVMCAS that includes much robust error checking and size management.
Allows better cherry-pick between branches