Handle on-type formatting requests

[MahdiBM]

To fully resolve #1805

TODO

• Hide behind an experimental flag
• Make sure the experimental flag is enable-able in VSCode?

[ahoppen]

Thanks for working on the implementation. I’m still a little skeptical how well this will work in practice, but I’m happy to iterate on it behind an experimental flag. If we do get it working, that would be great.

Make sure the experimental flag is enable-able in VSCode?

You should be able to enable the experimental feature in your Configuration File. There’s an option for that.

[ahoppen]

Changes look good to me once they are guarded behind an experimental feature.

[MahdiBM]

I'll handle the experimental-feature gating later 🙂.

[ahoppen]

Thank you. Just one comment on a comment 😉

[ahoppen]

Looks good. Thank you @MahdiBM

[ahoppen]

@swift-ci Please test

[ahoppen]

@swift-ci Please test Windows

[MahdiBM]

Fixed this by adding the import:

159 |   package func documentOnTypeFormatting(_ req: DocumentOnTypeFormattingRequest) async throws -> [TextEdit]? {
160 |     let snapshot = try documentManager.latestSnapshot(req.textDocument.uri)
161 |     guard let line = snapshot.lineTable.line(at: req.position.line) else {
    |                                         `- error: instance method 'line(at:callerFile:callerLine:)' is not available due to missing import of defining module 'SKUtilities'
162 |       return nil
163 |     }

[ahoppen]

Thanks for the fix.

@swift-ci Please test

[ahoppen]

Could you rebase your PR instead of merging main into your branch? It makes for a less convoluted git history.

[MahdiBM]

@ahoppen done

[ahoppen]

@swift-ci Please test

[ahoppen]

@swift-ci Please test Windows

[MahdiBM]

@ahoppen rebased with main again, this was the error which looks like unrelated to this PR?

sourcekit-lsp/Sources/BuildSystemIntegration/SwiftPMBuildSystem.swift:318:107: error: cannot convert value of type 'URL' to expected argument type 'TSCAbsolutePath' (aka 'AbsolutePath')
316 |       )
317 |     } else if let scratchDirectory = options.swiftPMOrDefault.scratchPath,
318 |       let scratchDirectoryPath = try? AbsolutePath(validating: scratchDirectory, relativeTo: AbsolutePath(projectRoot))
    |                                                                                                           `- error: cannot convert value of type 'URL' to expected argument type 'TSCAbsolutePath' (aka 'AbsolutePath')
319 |     {
320 |       location.scratchDirectory = scratchDirectoryPath

/home/build-user/sourcekit-lsp/Sources/BuildSystemIntegration/SwiftPMBuildSystem.swift:479:14: warning: When we drop support for Swift 5.10 we no longer need to adjust compiler arguments for the Modules move
477 | 
478 |     #if compiler(>=6.1)
479 |     #warning("When we drop support for Swift 5.10 we no longer need to adjust compiler arguments for the Modules move")
    |              `- warning: When we drop support for Swift 5.10 we no longer need to adjust compiler arguments for the Modules move
480 |     #endif
481 |     // Fix up compiler arguments that point to a `/Modules` subdirectory if the Swift version in the toolchain is less

[ahoppen]

Ah, that was because of a merge conflict that I resolved in #1838

[ahoppen]

@swift-ci Please test

[ahoppen]

@swift-ci Please test Windows

[ahoppen]

@swift-ci Please test Windows