Skip to content

[6.2] Handle both file paths and URLs from educational notes #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

hamishknight
Copy link
Contributor

@hamishknight hamishknight commented Jun 18, 2025

6.2 cherry-pick of #2175

  • Explanation: sourcekitd was recently switched to returning the swift.org URL for diagnostics groups/educational notes. Handle either an absolute path or URL.
  • Scope: Affects diagnostic groups/educational notes
  • Issue: rdar://153736166
  • Risk: Low, the fix is straightforward
  • Testing: Added tests to test suite
  • Reviewer: Alex Hoppen

sourcekitd was recently switched to returning the swift.org URL for
diagnostics groups/educational notes. Handle either an absolute path
or URL.
@hamishknight hamishknight requested a review from bnbarham June 18, 2025 14:43
@hamishknight hamishknight requested a review from a team as a code owner June 18, 2025 14:43
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight
Copy link
Contributor Author

@swift-ci please test Windows

@hamishknight hamishknight merged commit 1ddda8a into swiftlang:release/6.2 Jun 19, 2025
3 checks passed
@hamishknight hamishknight deleted the 2175-6.2 branch June 19, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants