Allow overriding SwiftPM's build directory with background indexing #2193
Conversation
If `scratchPath` is explicitly set, use it over the separate `index-build` arena even when background indexing is enabled.
|
@swift-ci please test |
|
@swift-ci please test |
|
Also applied formatting changes caused by swiftlang/swift-format#1039 (ideally we'd have github actions and use the latest release here but...) |
|
@swift-ci please test Windows platform |
| if options.backgroundIndexingOrDefault { | ||
| location.scratchDirectory = absProjectRoot.appending(components: ".build", "index-build") | ||
| } else if let scratchDirectory = options.swiftPMOrDefault.scratchPath { | ||
| if let scratchDirectory = options.swiftPMOrDefault.scratchPath { |
There was a problem hiding this comment.
I wonder if we should use an index-build folder within the scratch directory for background indexing. Say a user stores their build directory in .my-build instead of .build for some reason. In that case they might specify .my-build as the scratch path but we‘d probably still want to use a separate build arena for background indexing.
There was a problem hiding this comment.
I was torn on this. Technically there's no reason to match up their build + what's passed to sourcekit-lsp today, since we have a separate arena anyway. So if it is passed... seems weird to then tack on the arena?
There was a problem hiding this comment.
I guess… My opinion isn’t strong enough to argue about this.
If
scratchPathis explicitly set, use it over the separateindex-buildarena even when background indexing is enabled.