Move ClangLanguageService to its own module #2228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci Please test |
ahoppen
force-pushed
the
move-clanglanguageservice
branch
from
c4d423d to
6e6fc85
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Aug 8, 2025
bnbarham
reviewed
Aug 8, 2025
| @@ -4,6 +4,7 @@ add_executable(sourcekit-lsp | |||
| target_link_libraries(sourcekit-lsp PRIVATE | |||
| BuildServerIntegration | |||
| Diagnose | |||
| InProcessClient | |||
| LanguageServerProtocol | |||
| LanguageServerProtocolExtensions | |||
| LanguageServerProtocolJSONRPC | |||
There was a problem hiding this comment.
Not sure how this worked before, but we're apparently missing a DocCDocumentation here (we have a package import DocCDocumentation in Sources/SourceKitLSP/Workspace.swift)
There was a problem hiding this comment.
That's because we can't build DocC on Windows. All usages of DocC should be guarded by #if. Maybe I missed a #if now.
There was a problem hiding this comment.
Ah, I forgot about that :(
ahoppen
force-pushed
the
move-clanglanguageservice
branch
from
6e6fc85 to
634ec92
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m working on moving each of the three language services to its own module, ie. having a separate module for
ClangLanguageService,SwiftLanguageService, andDocumentationLanguageService. This should separate concerns for the three languages a little better instead of having them all in the singleSourceKitLSPmodule.The overall design is that the modules for the language services depend on the
SourceKitLSPmodule, so the language services need to be registered dynamically in aLanguageServiceRegistry. Other than that, a bit of code needed to be moved around but the changes should all be NFCs.https://github.com/ahoppen/sourcekit-lsp/tree/split-language-services contains the result of the final split. Getting there will probably take another couple of PRs.