[Explicit Module Builds] Allow generating a reproducer if precompiling a module errors out.#1147
Open
vsapsai wants to merge 2 commits intoswiftlang:mainfrom
Open
[Explicit Module Builds] Allow generating a reproducer if precompiling a module errors out.#1147vsapsai wants to merge 2 commits intoswiftlang:mainfrom
vsapsai wants to merge 2 commits intoswiftlang:mainfrom
Conversation
…g a module errors out. Reproducer-on-error was added for regular compilation (aka ClangCompileTaskAction) in 3c5f7fc. Not adding it for PrecompileClangModuleTaskAction was a mistake. rdar://171292607
vsapsai
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
owenv
approved these changes
Feb 27, 2026
Contributor
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproducer-on-error was added for regular compilation (aka ClangCompileTaskAction) in 3c5f7fc. Not adding it for PrecompileClangModuleTaskAction was a mistake.
rdar://171292607