[DO NOT MERGE] aggregate all changes necessary for Swift to build #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuietMisdreavus
force-pushed
the
QuietMisdreavus/swift-build
branch
from
2357644 to
cec14e6
Compare
- all the compilers we support have __has_include(), so use that instead of checking it in cmake - nothing in the library uses HAS__ATTRIBUTE__, so remove it
the win32 API uses some architecture-specific defines, but they're not defined by the MSVC compiler - they're defined directly in windows.h based on symbols defined by the MSVC compiler. rather than setting the architecture symbols ourselves, just import windows.h as a whole. this also needed to disable the short-name symbols in cmark-gfm.h, because there are some clashing symbols in win32 headers.
|
This PR now includes #40, which aggregates some CMake fixes for Windows and Linux. |
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
|
This PR now includes #41, which fixes a couple functions in |
QuietMisdreavus
force-pushed
the
QuietMisdreavus/swift-build
branch
from
e40b59a to
59e0b3c
Compare
QuietMisdreavus
force-pushed
the
QuietMisdreavus/swift-build
branch
from
59e0b3c to
fe486ef
Compare
on Windows SDK version 10.0.17763.0, the SDK headers spuriously trip this warning. since swift-cmark itself doesn't emit this warning on its own, diabling this warning will allow it to be built with this SDK.
|
This PR now includes #42, which fixes a problem when building with the Windows SDK used on the Swift CI servers. |
|
All the listed PRs that were originally combined into this branch have been merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dummy PR branch that aggregates the work necessary to build swift-cmark/gfm with the Swift compiler:
Sync in changes made to cmark-gfm after 2021-08-01 #29allow extensions to use!and^as special characters #30build: export targets info #27various CMake fixes and cleanup #40use const char * for string literals #41disable MSVC warning C5105 #42More changes may be added on as more issues are found.